Add Pulseq ROTATIONS support via extension hooks#730
Open
cncastillo wants to merge 1 commit intomasterfrom
Open
Add Pulseq ROTATIONS support via extension hooks#730cncastillo wants to merge 1 commit intomasterfrom
cncastillo wants to merge 1 commit intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #730 +/- ##
==========================================
- Coverage 91.03% 88.96% -2.07%
==========================================
Files 61 62 +1
Lines 3357 3380 +23
==========================================
- Hits 3056 3007 -49
- Misses 301 373 +72
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QuaternionRot <: ExtensioninKomaMRIBasewith hook methods:get_scale(::Type{QuaternionRot})get_scanf_format(::Type{QuaternionRot})get_EXT_type_from_symbol(::Val{:ROTATIONS})Base.:*(q::QuaternionRot, grads)Base.transpose(q::QuaternionRot)andBase.adjoint(q::QuaternionRot)apply_rotations!(seq; reverse=false)KomaMRIBase/src/datatypes/sequence/EXT.jlexports/includes.KomaMRIFiles.read_seqwithapply_rotations=truekwarg and apply rotations at the end of parsing by default.KomaMRIBaseandKomaMRIFiles(includinglps.seqfixture) for forward/reverse rotation behavior and read-time application control.References
extension ROTATIONSfrom Pulseq 1.5.1 #728Validation
julia --project=test -q --startup-file=no test/runtests.jlinKomaMRIBase: 211/211 passedjulia --project=test -q --startup-file=no test/runtests.jlinKomaMRIFiles: 24270/24270 passedNote
For the specific
lps.seqsequence in #728, the resulting rotation behavior still does not appear fully correct end-to-end. However, for trapezoids and simpler gradients, the quaternion rotation path appears to behave as expected based on the added unit/integration tests.